Eli Mesika has submitted this change and it was merged. Change subject: core: Underscores in tag names break tags ......................................................................
core: Underscores in tag names break tags Problem were in the usage of the deprecated RefObject objects to pass strings in *AutoCompleter* classes . This was replaced with a native String usage The signature and calls to formatValue had changed to get a Pair<String,String> instead of two Strings encapsulated by a RefObject. Change-Id: I8c0d48aa8ab693149fd1dcc080eddd6d2f9ba4ed Bug-Url : https://bugzilla.redhat.com/show_bug.cgi?id=949484 Signed-off-by: Eli Mesika <[email protected]> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/BaseConditionFieldAutoCompleter.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/DiskConditionFieldAutoCompleter.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/IConditionFieldAutoCompleter.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VdcUserConditionFieldAutoCompleter.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VmConditionFieldAutoCompleter.java M backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/AuditLogConditionFieldAutoCompleterTest.java 6 files changed, 82 insertions(+), 93 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17266 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8c0d48aa8ab693149fd1dcc080eddd6d2f9ba4ed Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
