Liran Zelkha has posted comments on this change.

Change subject: tools: Add script to dump heap
......................................................................


Patch Set 1: (4 inline comments)

....................................................
File packaging/bin/engine-heap-dump.sh
Line 11: fi
Line 12: 
Line 13: # Check tha the jmap tools is available and correct version (it won't 
usually
Line 14: # be available, as it is part of the JDK and we only require the JRE):
Line 15: JMAP=`su - "${ENGINE_USER}" -s /bin/sh -c "which jmap 2> /dev/null"`
Done
Line 16: if [ -z "${JMAP}" ]
Line 17: then
Line 18:     die "The jmap tool is not available."
Line 19: fi


Line 14: # be available, as it is part of the JDK and we only require the JRE):
Line 15: JMAP=`su - "${ENGINE_USER}" -s /bin/sh -c "which jmap 2> /dev/null"`
Line 16: if [ -z "${JMAP}" ]
Line 17: then
Line 18:     die "The jmap tool is not available."
Done
Line 19: fi
Line 20: 
Line 21: # Compute the locations of the histogram and heap dump files:
Line 22: DATE=`date +%Y%m%d_%H%M%S`


Line 14: # be available, as it is part of the JDK and we only require the JRE):
Line 15: JMAP=`su - "${ENGINE_USER}" -s /bin/sh -c "which jmap 2> /dev/null"`
Line 16: if [ -z "${JMAP}" ]
Line 17: then
Line 18:     die "The jmap tool is not available."
Any JDK for the env will work.
Line 19: fi
Line 20: 
Line 21: # Compute the locations of the histogram and heap dump files:
Line 22: DATE=`date +%Y%m%d_%H%M%S`


Line 19: fi
Line 20: 
Line 21: # Compute the locations of the histogram and heap dump files:
Line 22: DATE=`date +%Y%m%d_%H%M%S`
Line 23: HISTO="${ENGINE_LOG}/histo.${DATE}_${PID}.txt"
What's the env value for DUMPS?
Line 24: DUMP="${ENGINE_LOG}/dump.${DATE}_${PID}.bin"
Line 25: 
Line 26: # Write the histogram:
Line 27: echo "Writing histogram to ${HISTO} ..."


-- 
To view, visit http://gerrit.ovirt.org/15359
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5ea3355eafbb07d2b6c9594abcc282c139d2f31f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Liran Zelkha <liran.zel...@gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to