Alex Lourie has posted comments on this change. Change subject: refactored cdrom configuration ......................................................................
Patch Set 3: Looks good to me, but someone else must approve (1 inline comment) .................................................... File src/plugins/ovirt-hosted-engine-setup/vm/boot_cdrom.py Line 97: while not valid: Line 98: self.environment[ Line 99: ohostedcons.VMEnv.CDROM Line 100: ] = self.dialog.queryString( Line 101: name='ovehosted_vmenv_cdrom', Should this be capitalized? Line 102: note=_( Line 103: 'Please specify path to installation media ' Line 104: 'you would like to use [@DEFAULT@]: ' Line 105: ), -- To view, visit http://gerrit.ovirt.org/16755 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I83688a74d1f478b733bcce8bb838d09256360b8a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Lev Veyde <[email protected]> Gerrit-Reviewer: Moran Goldboim <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
