Sandro Bonazzola has posted comments on this change. Change subject: packaging: setup: remove legacy setup ......................................................................
Patch Set 2: Looks good to me, but someone else must approve (1 inline comment) minor comment inline .................................................... File packaging/bin/engine-upgrade.sh Line 3: cat >&2 <<__EOF__ Line 4: engine-upgrade is obsoleted Line 5: please run engine-setup for upgrading package. Line 6: __EOF__ Line 7: What about: echo " engine-upgrade is obsoleted please run engine-setup for upgrading package. " or also adding a call to eval_gettext sourced from /usr/bin/gettext ? -- To view, visit http://gerrit.ovirt.org/17204 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ae205aa17eea390b82fe32be9f517cfb55dbe0f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Moran Goldboim <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
