Ori Liel has posted comments on this change.
Change subject: api: API to tear down VM disk after backup.
......................................................................
Patch Set 3: (3 inline comments)
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/VmDiskResource.java
Line 66:
Line 67: @POST
Line 68: @Formatted
Line 69: @Actionable
Line 70: @Path("tearDownBackup")
path should be all lower-case letter.
Line 71: @Consumes({MediaType.APPLICATION_XML, MediaType.APPLICATION_JSON,
MediaType.APPLICATION_X_YAML})
Line 72: public Response tearDownBackup(Action action);
Line 73:
Line 74: @PUT
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
Line 425: urlparams: {}
Line 426: headers:
Line 427: Content-Type: {value: application/xml|json, required: true}
Line 428: Correlation-Id: {value: 'any string', required: false}
Line 429: - name:
/api/vms/{vm:id}/disks/{disk:id}/tearDownBackup|rel=tearDownBackup
lowercase: tearDownBackup-->teardownbackup
Line 430: request:
Line 431: body:
Line 432: parameterType: Action
Line 433: signatures: []
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmDiskResource.java
Line 114: new
TearDownBackupParameters(((BackendVmDisksResource) collection).parentId,
Line 115: guid);
Line 116: return doAction(VdcActionType.TearDownBackup, params, action);
Line 117: }
Line 118:
We should add a test for this flow in BackendVmDiskResourceTest
Line 119: protected Disk getDisk() {
Line 120: return performGet(VdcQueryType.GetDiskByDiskId, new
IdQueryParameters(guid));
Line 121: }
Line 122:
--
To view, visit http://gerrit.ovirt.org/15174
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd3fb443932d4bb8012e54fa7189a0766d0bcbaf
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharad Mishra <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Deepak C Shetty <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
Gerrit-Reviewer: Sharad Mishra <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
