Juan Hernandez has uploaded a new change for review. Change subject: core: Cleanup LdapSearchByIdParameters ......................................................................
core: Cleanup LdapSearchByIdParameters This change makes several cleanups in the LdapSearchByIdParameters class, including the replacement of ArrayList with List. Change-Id: Id263a1fc19579275a3358405a2e6f441993b7578 Signed-off-by: Juan Hernandez <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/InternalGetAdUserByUserIdListCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapGetAdUserByUserIdListCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapSearchByIdListParameters.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapSearchByUserIdListParameters.java 4 files changed, 11 insertions(+), 27 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/05/17205/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/InternalGetAdUserByUserIdListCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/InternalGetAdUserByUserIdListCommand.java index 12b6087..a1b1433 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/InternalGetAdUserByUserIdListCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/InternalGetAdUserByUserIdListCommand.java @@ -9,7 +9,7 @@ public class InternalGetAdUserByUserIdListCommand extends InternalBrokerCommandBase { - private java.util.ArrayList<Guid> getUserIds() { + private List<Guid> getUserIds() { return ((LdapSearchByIdListParameters) getParameters()).getUserIds(); } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapGetAdUserByUserIdListCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapGetAdUserByUserIdListCommand.java index ca43fe8..0b35942 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapGetAdUserByUserIdListCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapGetAdUserByUserIdListCommand.java @@ -16,7 +16,7 @@ */ public class LdapGetAdUserByUserIdListCommand extends LdapBrokerCommandBase { - private java.util.ArrayList<Guid> getUserIds() { + private List<Guid> getUserIds() { return ((LdapSearchByIdListParameters) getParameters()).getUserIds(); } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapSearchByIdListParameters.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapSearchByIdListParameters.java index 4f6c487..d5d998d 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapSearchByIdListParameters.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapSearchByIdListParameters.java @@ -1,20 +1,18 @@ package org.ovirt.engine.core.bll.adbroker; +import java.util.List; + import org.ovirt.engine.core.compat.Guid; public class LdapSearchByIdListParameters extends LdapBrokerBaseParameters { - private java.util.ArrayList<Guid> privateUserIds; + private List<Guid> userIds; - public java.util.ArrayList<Guid> getUserIds() { - return privateUserIds; + public List<Guid> getUserIds() { + return userIds; } - private void setUserIds(java.util.ArrayList<Guid> value) { - privateUserIds = value; - } - - public LdapSearchByIdListParameters(String domain, java.util.ArrayList<Guid> userIds) { + public LdapSearchByIdListParameters(String domain, List<Guid> userIds) { super(domain); - setUserIds(userIds); + this.userIds = userIds; } } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapSearchByUserIdListParameters.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapSearchByUserIdListParameters.java index b412605..3702749 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapSearchByUserIdListParameters.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapSearchByUserIdListParameters.java @@ -1,25 +1,13 @@ -/** - * - */ package org.ovirt.engine.core.bll.adbroker; -import java.util.ArrayList; +import java.util.List; import org.ovirt.engine.core.compat.Guid; public class LdapSearchByUserIdListParameters extends LdapSearchByIdListParameters { - - private boolean performGroupsQueryInsideCmd = true; - /** - * @param domain - * @param userIds - */ - public LdapSearchByUserIdListParameters(String domain, ArrayList<Guid> userIds) { - super(domain, userIds); - } - public LdapSearchByUserIdListParameters(String domain, ArrayList<Guid> userIds, boolean performGroupsQueryInsideCmd) { + public LdapSearchByUserIdListParameters(String domain, List<Guid> userIds, boolean performGroupsQueryInsideCmd) { super(domain, userIds); this.performGroupsQueryInsideCmd = performGroupsQueryInsideCmd; } @@ -27,6 +15,4 @@ public boolean getPerformGroupsQueryInsideCmd() { return performGroupsQueryInsideCmd; } - - } -- To view, visit http://gerrit.ovirt.org/17205 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id263a1fc19579275a3358405a2e6f441993b7578 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
