Alon Bar-Lev has posted comments on this change. Change subject: packaging: logging: port notifier to logrotate ......................................................................
Patch Set 1: (1 inline comment) .................................................... File ovirt-engine.spec.in Line 908: %config(noreplace) %{engine_etc}/engine-manage-domains/engine-manage-domains.conf Line 909: %{engine_etc}/engine-manage-domains/log4j.xml Line 910: Line 911: # Configuration files for the notifier: Line 912: %config %{_sysconfdir}/logrotate.d/ovirt-engine-notifier same as engine log rotate. I want to override when upgrade, as we have many new changes and logs to be rotated, leaving user's file will cause missing these. Line 913: %dir %{engine_etc}/notifier Line 914: %ghost %config(noreplace) %{engine_etc}/notifier/notifier.conf Line 915: %dir %{engine_etc}/notifier/notifier.conf.d Line 916: %config %{engine_etc}/notifier/log4j.xml -- To view, visit http://gerrit.ovirt.org/17123 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If0c14f88fdca4ac61e22a1e2585e2cf163b3dbbd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches