Moti Asayag has posted comments on this change. Change subject: WIP core: remove networkName from VmNetworkInterface ......................................................................
Patch Set 9: (1 inline comment) .................................................... File packaging/dbscripts/create_dwh_views.sql Line 288: vm_interface._create_date AS create_date, Line 289: vm_interface._update_date AS update_date Line 290: FROM vm_interface Line 291: LEFT OUTER JOIN vnic_profiles ON vnic_profiles.id = vm_interface.vnic_profile_id Line 292: JOIN network ON network.id = vnic_profiles.network_id side comment. as this patch is about to be abandoned, the select above will return only vm_interface which are attached to any network. However it will filter out any vnics which aren't attached to any network. The proper way should be performing the join between the vnic_profiles to the network first, and then the left outer join between the vm_interface to it. Line 293: WHERE vmt_guid IS NULL AND Line 294: ((vm_interface._create_date > Line 295: (SELECT var_datetime Line 296: FROM dwh_history_timekeeping -- To view, visit http://gerrit.ovirt.org/16899 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibe73642f02665360617ac33ee2f51e3e37cdd58c Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
