ofri masad has posted comments on this change. Change subject: engine:Trusted Compute Pools - Open Attestation integration with oVirt engine ......................................................................
Patch Set 1: (3 inline comments) .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java Line 354: VDS_GROUP_CANNOT_UPDATE_COMPATIBILITY_VERSION_WITH_LOWER_HOSTS(ErrorType.INCOMPATIBLE_VERSION), Line 355: VDS_GROUP_CANNOT_UPDATE_VDS_UP(ErrorType.CONFLICT), Line 356: VDS_GROUP_CANNOT_ADD_COMPATIBILITY_VERSION_WITH_LOWER_STORAGE_POOL(ErrorType.INCOMPATIBLE_VERSION), Line 357: VDS_GROUP_CANNOT_REMOVE_HAS_VM_POOLS(ErrorType.CONFLICT), Line 358: VDS_GROUP_CANNOT_DO_ACTION_ATTESTATION_SERVER_NO_CONFIGURE(ErrorType.ATTESTATION_SERVER_ERROR), please change name to: VDS_GROUP_CANNOT_SET_TRUSTED_ATTESTATION_SERVER_NOT_CONFIGURED Line 359: NETWORK_HOST_IS_BUSY(ErrorType.CONFLICT), Line 360: ACTION_TYPE_FAILED_NETWORK_NAME_IN_USE(ErrorType.CONFLICT), Line 361: ACTION_TYPE_FAILED_NETWORK_IN_USE(ErrorType.CONFLICT), Line 362: NETWORK_NOT_EXISTS(ErrorType.BAD_PARAMETERS), .................................................... Commit Message Line 7: engine:Trusted Compute Pools - Open Attestation integration with oVirt engine Line 8: Line 9: Detailed description: http://wiki.ovirt.org/Trusted_compute_pools Line 10: Line 11: For the case that TCP not configured correctly(not configured), when user try to create a trusted cluster, should fail it and give user a notification. Please change message: "Add rule to canDoAction to block setting of cluster as trusted when Attestation Server is not defined properly" Line 12: Line 13: Change-Id: I03aba74d09ffe8eb580b369e07232370b3954dec Line 14: Signed-off-by: Gang Wei <gang....@intel.com> .................................................... File frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java Line 1925: Line 1926: @DefaultStringValue("Host must be migratable when highly available is selected") Line 1927: String hostIsHa(); Line 1928: Line 1929: @DefaultStringValue("Can't switch host cluster between trust cluster and non-trust cluster due to host existed in the cluster") unrelated to this patch. but is you fix this please change to: "Cannot change Cluster's trust support state while host/s existed in the cluster" Line 1930: String trustedServiceDisabled(); -- To view, visit http://gerrit.ovirt.org/16987 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I03aba74d09ffe8eb580b369e07232370b3954dec Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gang Wei <gang....@intel.com> Gerrit-Reviewer: Dave Chen <wei.d.c...@intel.com> Gerrit-Reviewer: Emily Zhang <lijuan.zh...@intel.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-Reviewer: ofri masad <oma...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
