Arik Hadas has posted comments on this change.
Change subject: core: minor cleanups in MemoryImageRemover class
......................................................................
Patch Set 4: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryImageRemover.java
Line 19: import org.ovirt.engine.core.utils.log.LogFactory;
Line 20:
Line 21: public abstract class MemoryImageRemover {
Line 22: private static final Log log =
LogFactory.getLog(MemoryImageRemover.class);
Line 23: private static final int NUM_OF_UUIDS_IN_MEMORT_STATE = 6;
Done
Line 24:
Line 25: private TaskHandlerCommand<?> enclosingCommand;
Line 26: private boolean startPollingTasks;
Line 27:
Line 55: private boolean removeMemoryVolumes(String memVols) {
Line 56: List<Guid> guids = GuidUtils.getGuidListFromString(memVols);
Line 57:
Line 58: if (guids.size() != NUM_OF_UUIDS_IN_MEMORT_STATE) {
Line 59: log.warnFormat("Cannot remove memory volumes, invalid
format: {0}", memVols);
no it can't, because it is called from the removeMemoryVolume (line 45) which
invokes it after checking 'isMemoryStateRemovable' - this method should not
return true for empty memory state representation
Line 60: return true;
Line 61: }
Line 62:
Line 63: Guid memoryImageRemovalTaskId = removeMemoryImage(guids);
--
To view, visit http://gerrit.ovirt.org/16828
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I14cb0bb13d0d103bbc170abcf0348a6909051f2c
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
