Arik Hadas has posted comments on this change.
Change subject: core: fix the hierarchy of memory images removers
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryImageRemoverOnDataDomain.java
Line 15: super(vm, enclosingCommand);
Line 16: }
Line 17:
Line 18: @Override
Line 19: protected DeleteImageGroupVDSCommandParameters
buildDeleteMemoryImageParams(List<Guid> guids) {
if you agree with the comment above, then we have two solutions I can think of:
1. keep it as is
2. in MemoryStateRemover to have a method with default implementation instead
of the abstract method (with false values for force-delete and post-zero), and
override it in subclasses to set the post-zero value.
the advantage of the second is not to set the guids in the same way in two
different places, the disadvantage is that it will make the code a little more
complicated to follow.
what do you think?
Line 20: return new DeleteImageGroupVDSCommandParameters(
Line 21: guids.get(1), guids.get(0), guids.get(2),
isPostZero(), false);
Line 22: }
Line 23:
--
To view, visit http://gerrit.ovirt.org/16826
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id7cada7b6f9a3356afcac0dd2856d6a02cf1f9fd
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
