Yair Zaslavsky has posted comments on this change.
Change subject: core: Add the ability to create a dummy task in case of VDSM
failure
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
Line 377:
Line 378: private void clearAsyncTasksWithOutVdsmId() {
Line 379: for (Guid asyncTaskId :
getReturnValue().getTaskPlaceHolderIdList()) {
Line 380: AsyncTasks task = getAsyncTaskDao().get(asyncTaskId);
Line 381: if (task != null &&
Guid.isNullOrEmpty(task.getVdsmTaskId())) {
Actually, the task cannot be null as place holder id list is actually the list
of primary keys of tasks in DB.
Line 382:
AsyncTaskManager.removeTaskFromDbByTaskId(task.getTaskId());
Line 383: }
Line 384: }
Line 385: }
--
To view, visit http://gerrit.ovirt.org/16642
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6e977596af52c81a1aed1b8748a30b9425c62fa3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
