Omer Frenkel has posted comments on this change.
Change subject: core: prevent removing vm from export domain while it is being
imported
......................................................................
Patch Set 4: I would prefer that you didn't submit this
(5 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
Line 138: }
Line 139:
Line 140: private String getVmIsBeingImportedMessage() {
Line 141: StringBuilder builder = new
StringBuilder(VdcBllMessages.ACTION_TYPE_FAILED_VM_IS_BEING_IMPORTED.name());
Line 142: builder.append(String.format("$VmName %1$s", getVmName()));
possible NPE?
Line 143: return builder.toString();
Line 144: }
Line 145:
Line 146: protected ImportVmCommand(Guid commandId) {
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmFromImportExportCommand.java
Line 59: }
Line 60:
Line 61: private String getVmIsBeingRemovedFromExportDomainMessage() {
Line 62: StringBuilder builder = new
StringBuilder(VdcBllMessages.ACTION_TYPE_FAILED_VM_IS_BEING_REMOVED_FROM_EXPORT_DOMAIN.name());
Line 63: builder.append(String.format("$VmName %1$s", getVmName()));
boom
Line 64: return builder.toString();
Line 65: }
Line 66:
Line 67: @Override
....................................................
File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
Line 548: ACTION_TYPE_FAILED_SNAPSHOT_IS_BEING_TAKEN_FOR_VM=Cannot ${action}
${type}. Snapshot is currently being created for VM ${VmName}.
Line 549: ACTION_TYPE_FAILED_DISK_IS_USED_FOR_CREATE_VM=Cannot ${action}
${type}. This disk is currently in use to create VM ${VmName}.
Line 550: ACTION_TYPE_FAILED_DISK_IS_BEING_REMOVED=Cannot ${action} ${type}.
Disk ${DiskName} is being removed.
Line 551: ACTION_TYPE_FAILED_TEMPLATE_IS_BEING_EXPORTED=Cannot ${action}
${type}. Template ${TemplateName} is being exported.
Line 552: ACTION_TYPE_FAILED_VM_IS_BEING_IMPORTED=Cannot ${action} ${type}. VM
${VmName} is being imported.
other message is missing
Line 553: ACTION_TYPE_FAILED_TEMPLATE_IS_BEING_REMOVED=Cannot ${action}
${type}. Template ${TemplateName} is being removed.
Line 554: ACTION_TYPE_FAILED_DISK_IS_USED_BY_GET_ALIGNMENT=Cannot ${action}
${type}. Disk ${DiskAlias} alignment is currently being determined.
Line 555: ACTION_TYPE_FAILED_DISK_IS_BEING_EXPORTED=Cannot ${action} ${type}.
Disk ${DiskAlias} is being exported.
Line 556: NETWORK_BOND_HAVE_ATTACHED_VLANS=Bond attached to vlan, remove bonds
vlan first
....................................................
File
frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
Line 536: ACTION_TYPE_FAILED_SNAPSHOT_IS_BEING_TAKEN_FOR_VM=Cannot ${action}
${type}. Snapshot is currently being created for VM ${VmName}.
Line 537: ACTION_TYPE_FAILED_DISK_IS_USED_FOR_CREATE_VM=Cannot ${action}
${type}. This disk is currently in use to create VM ${VmName}.
Line 538: ACTION_TYPE_FAILED_DISK_IS_BEING_REMOVED=Cannot ${action} ${type}.
Disk ${DiskName} is being removed.
Line 539: ACTION_TYPE_FAILED_TEMPLATE_IS_BEING_EXPORTED=Cannot ${action}
${type}. Template ${TemplateName} is being exported.
Line 540: ACTION_TYPE_FAILED_VM_IS_BEING_IMPORTED=Cannot ${action} ${type}. VM
${VmName} is being imported.
and here
Line 541: ACTION_TYPE_FAILED_TEMPLATE_IS_BEING_REMOVED=Cannot ${action}
${type}. Template ${TemplateName} is being removed.
Line 542: ACTION_TYPE_FAILED_DISK_IS_USED_BY_GET_ALIGNMENT=Cannot ${action}
${type}. Disk ${DiskAlias} alignment is currently being determined.
Line 543: ACTION_TYPE_FAILED_DISK_IS_BEING_EXPORTED=Cannot ${action} ${type}.
Disk ${DiskAlias} is being exported.
Line 544: NETWORK_BOND_HAVE_ATTACHED_VLANS=Bond attached to vlan, remove bonds
vlan first
....................................................
File
frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
Line 553: ACTION_TYPE_FAILED_SNAPSHOT_IS_BEING_TAKEN_FOR_VM=Cannot ${action}
${type}. Snapshot is currently being created for VM ${VmName}.
Line 554: ACTION_TYPE_FAILED_DISK_IS_USED_FOR_CREATE_VM=Cannot ${action}
${type}. This disk is currently in use to create VM ${VmName}.
Line 555: ACTION_TYPE_FAILED_DISK_IS_BEING_REMOVED=Cannot ${action} ${type}.
Disk ${DiskName} is being removed.
Line 556: ACTION_TYPE_FAILED_TEMPLATE_IS_BEING_EXPORTED=Cannot ${action}
${type}. Template ${TemplateName} is being exported.
Line 557: ACTION_TYPE_FAILED_VM_IS_BEING_IMPORTED=Cannot ${action} ${type}. VM
${VmName} is being imported.
..
Line 558: ACTION_TYPE_FAILED_TEMPLATE_IS_BEING_REMOVED=Cannot ${action}
${type}. Template ${TemplateName} is being removed.
Line 559: ACTION_TYPE_FAILED_DISK_IS_USED_BY_GET_ALIGNMENT=Cannot ${action}
${type}. Disk ${DiskAlias} alignment is currently being determined.
Line 560: ACTION_TYPE_FAILED_DISK_IS_BEING_EXPORTED=Cannot ${action} ${type}.
Disk ${DiskAlias} is being exported.
Line 561: NETWORK_BOND_HAVE_ATTACHED_VLANS=Bond attached to vlan, remove bonds
vlan first
--
To view, visit http://gerrit.ovirt.org/16955
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5c34612f754375a9d15816e9972671e1b13023ad
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
