Maor Lipchuk has posted comments on this change. Change subject: engine: Don't use ValueObjectMap for PM Options ......................................................................
Patch Set 1: (1 inline comment) .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetNewVdsFenceStatusParameters.java Line 1: package org.ovirt.engine.core.common.queries; Line 2: Line 3: import java.util.HashMap; Are you sure we can't use map here? Line 4: import org.ovirt.engine.core.common.businessentities.FenceAgentOrder; Line 5: import org.ovirt.engine.core.compat.Guid; Line 6: Line 7: public class GetNewVdsFenceStatusParameters extends VdcQueryParametersBase { -- To view, visit http://gerrit.ovirt.org/16817 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e0bf7aedeff0e0b999921298b34494e5e179a1f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches