Michael Pasternak has posted comments on this change.

Change subject: restapi: backward compatibility for cluster's scheduling policy
......................................................................


Patch Set 18: (1 inline comment)

....................................................
File 
backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/ClusterMapper.java
Line 141:         if (model.isSetPolicy()) {
Line 142:             SchedulingPolicyType policyType = 
SchedulingPolicyType.fromValue(model.getPolicy());
Line 143:             if (policyType != null) {
Line 144:                 entity.setClusterPolicyId(null);
Line 145:                 
entity.setClusterPolicyName(policyType.name().toLowerCase());
please check it works, i'e lower case here ^
Line 146:             }
Line 147:         }
Line 148:         if (model.isSetThresholds()) {
Line 149:             SchedulingPolicyThresholds thresholds = 
model.getThresholds();


-- 
To view, visit http://gerrit.ovirt.org/16607
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4edd7313401670ca225b32d19dd7ad961ccd1b6a
Gerrit-PatchSet: 18
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Ori Liel <ol...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to