Sandro Bonazzola has posted comments on this change.
Change subject: packaging: setup: exit if selinux is disabled
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File packaging/fedora/setup/engine_validators.py
Line 138: (out, rc) = utils.execCmd(cmdList=cmd, failOnError=True)
Line 139: if "Disabled" in out:
Line 140: logging.debug("SELINUX was found in disabled mode")
Line 141: print output_messages.MSG_ENABLE_SELINUX
Line 142: sys.exit(1)
I can see several bugs related to selinux disabled in bugzilla. In engine-setup
we're calling _configureSelinuxBoolean that need selinux enabled. In
engine-setup-2 I can see that selinux plugin that do the same thing done by
_configureSelinuxBoolean is disabled if semanage is not found but I think it
will fail if semanage is found but selinux disabled. So I think we need to
check selinux enabled also there.
Line 143: #Need httpd stopped for later port validation
Line 144: logging.debug("stopping httpd service")
Line 145: utils.Service(basedefs.HTTPD_SERVICE_NAME).stop()
Line 146: return True
--
To view, visit http://gerrit.ovirt.org/16771
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4242c7aedd805f6d7e4ffcc7dc6dd77a31c63dee
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
