Laszlo Hornyak has uploaded a new change for review. Change subject: engine: fix broken nullcheck ......................................................................
engine: fix broken nullcheck fixes a broken null-check in VmPoolCommandBase Change-Id: Icee2ef9cdeb8feec2dd6476ab9fa27051011a230 Signed-off-by: Laszlo Hornyak <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolCommandBase.java 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/85/16985/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolCommandBase.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolCommandBase.java index a52678b..48dcc22 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolCommandBase.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolCommandBase.java @@ -213,11 +213,11 @@ protected static boolean canRunPoolVm(Guid vmId, ArrayList<String> messages) { VM vm = DbFacade.getInstance().getVmDao().get(vmId); - VDSGroup vdsGroup = DbFacade.getInstance().getVdsGroupDao().get(vm.getVdsGroupId()); if (vm == null) { messages.add(VdcBllMessages.ACTION_TYPE_FAILED_VM_NOT_FOUND.name()); return false; } + VDSGroup vdsGroup = DbFacade.getInstance().getVdsGroupDao().get(vm.getVdsGroupId()); // TODO: This is done to keep consistency with VmDAO.getById. // It can probably be removed, but that requires some more research -- To view, visit http://gerrit.ovirt.org/16985 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Icee2ef9cdeb8feec2dd6476ab9fa27051011a230 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
