ofri masad has uploaded a new change for review. Change subject: core: Fix optimization of NetworkQoSDaoFacadeImpl ......................................................................
core: Fix optimization of NetworkQoSDaoFacadeImpl remove use of ResultSet.getString() for non string fields. Change-Id: Ia947c0cc948eb036f70d629872923e3cd80b3d53 Signed-off-by: Ofri Masad <[email protected]> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/NetworkQoSDaoFacadeImpl.java 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/83/16983/1 diff --git a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/NetworkQoSDaoFacadeImpl.java b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/NetworkQoSDaoFacadeImpl.java index d204b99..4c8b523 100644 --- a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/NetworkQoSDaoFacadeImpl.java +++ b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/NetworkQoSDaoFacadeImpl.java @@ -19,8 +19,8 @@ } private static Integer getIntegerOrNull(ResultSet rs, String columnName) throws SQLException { - String string = rs.getString(columnName); - return string == null ? null : Integer.parseInt(string); + int i = rs.getInt(columnName); + return rs.wasNull() ? null : i; } @Override @@ -36,9 +36,9 @@ public NetworkQoS mapRow(ResultSet rs, int rowNum) throws SQLException { NetworkQoS entity = new NetworkQoS(); - entity.setId(Guid.createGuidFromString(rs.getString("id"))); + entity.setId(getGuid(rs, "id")); entity.setName(rs.getString("name")); - entity.setStoragePoolId(Guid.createGuidFromString(rs.getString("storage_pool_id"))); + entity.setStoragePoolId(getGuid(rs, "storage_pool_id")); entity.setInboundAverage(getIntegerOrNull(rs, "inbound_average")); entity.setInboundPeak(getIntegerOrNull(rs, "inbound_peak")); entity.setInboundBurst(getIntegerOrNull(rs, "inbound_burst")); -- To view, visit http://gerrit.ovirt.org/16983 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia947c0cc948eb036f70d629872923e3cd80b3d53 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
