Mike Kolesnik has posted comments on this change. Change subject: engine: Install Openstack agents on the host ......................................................................
Patch Set 10: Hi Alon, ObjectUtils.toString(x) will return empty String if x == null. If we just use x.toString() obviously we'd get an NPE if x == null. I just preferred to use ObjectUtils.toString() since it's readable, compact and well documented, but if you prefer I can change all logic to: x == null ? "" : x -- To view, visit http://gerrit.ovirt.org/16851 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib365bc5e7db9b0c1d070eb9182b554cd830e797d Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
