Lior Vernia has posted comments on this change. Change subject: webadmin: add Network Provider tab to add host ......................................................................
Patch Set 16: (2 inline comments) .................................................... File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java Line 846: } Line 847: }); Line 848: setProviderType(new ListModel()); Line 849: getProviderType().setIsChangable(false); Line 850: getProviderType().setIsAvailable(false); Because when it is displayed, after a provider is chosen, I don't want it to be changeable. The changeability never changes here, only the availabiity. Line 851: setProviderPluginType(new ListModel()); Line 852: getProviderPluginType().setIsChangable(false); Line 853: getProviderPluginType().setIsAvailable(false); Line 854: neutronAgentSection = new NeutronAgentBehavior(getProviderType(), getProviderPluginType()); Line 870: getProviderPluginType().setSelectedItem(NeutronPluginTranslator.getDisplayStringForPluginName(pluginName)); Line 871: } Line 872: } Line 873: Line 874: private void initExternalNetworksList() { Done Line 875: AsyncQuery getProvidersQuery = new AsyncQuery(); Line 876: getProvidersQuery.asyncCallback = new INewAsyncCallback() { Line 877: @Override Line 878: public void onSuccess(Object model, Object result) -- To view, visit http://gerrit.ovirt.org/16045 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0a23854ea8db144f375aae768867bf233c930e4e Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches