Kiril Nesenko has posted comments on this change.
Change subject: pki: Allow changing the manager hostname
......................................................................
Patch Set 17: (4 inline comments)
....................................................
File packaging/bin/ovirt-engine-rename-manager-host
Line 34: aia_in_ca=no
Line 35:
Line 36: BCKSFX=".$(date +%Y-%m-%d-%H-%M-%S).bckrenovirt"
Line 37:
Line 38: TMP=`mktemp -d /tmp/ovirt-engine-rename-manager-host.XXXXXX`
Please decide which syntax do you want to use in the script.
`` or $()
Line 39: changedfiles=$TMP/changedfiles
Line 40:
Line 41: cleanup(){
Line 42: #rm -rf "${TMP}"
Line 38: TMP=`mktemp -d /tmp/ovirt-engine-rename-manager-host.XXXXXX`
Line 39: changedfiles=$TMP/changedfiles
Line 40:
Line 41: cleanup(){
Line 42: #rm -rf "${TMP}"
why do you comment this line ?
Line 43: :
Line 44: }
Line 45:
Line 46: trap cleanup EXIT
Line 110: die "Failed updating ${apachecert}"
Line 111:
Line 112: echo
Line 113: echo "Restating apache httpd service:"
Line 114: service httpd restart
maybe you should add a validation that the script is executed by a root user ?
Line 115: echo "done."
Line 116: echo
Line 117: }
Line 118:
Line 181: elif echo "${line}" | grep -q '^file.[0-9]*.md5' && \
Line 182: grep -q "^${filename}\$"
"${changedfiles}" && \
Line 183: ! grep -q "^${filename}\$"
"${finishedfiles}"; then
Line 184: echo "${filename}" >> "${finishedfiles}"
Line 185: md5=$(md5sum "${filename}" | awk '{print $1}')
Please use `` or $() all over the script.
Line 186: groupfile="${GROUPSDIR}/${group}"
Line 187: if ! [ -f "${groupfile}" ]; then
Line 188: # Write group header
Line 189: cat << __EOF__ > "${groupfile}"
--
To view, visit http://gerrit.ovirt.org/16404
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb03d638be1e030865d3ebabaa163ca9be9e70ce
Gerrit-PatchSet: 17
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knese...@redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
