Moti Asayag has posted comments on this change. Change subject: engine: Add agent configuration to provider ......................................................................
Patch Set 2: Looks good to me, approved (1 inline comment) Please add a valid value other than null for the agent configuration to the fixture. This can come as a next patch, at the meantime acking this patch, not to prevent its merge. .................................................... File backend/manager/modules/dal/src/test/resources/fixtures.xml Line 743: <null/> Line 744: <null/> Line 745: <value>bubu</value> Line 746: <value>LINUX_BRIDGE</value> Line 747: <null/> Please add a valid value other than null for the agent configuration. Line 748: </row> Line 749: </table> Line 750: Line 751: <table name="network"> -- To view, visit http://gerrit.ovirt.org/16850 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If93d24404815c080253207f8e9b8f781fac0c7f6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
