Eli Mesika has posted comments on this change. Change subject: userportal : Fix DiskForVmGuid high CPU ......................................................................
Patch Set 2: (3 inline comments) .................................................... File packaging/dbscripts/all_disks_sp.sql Line 51: Line 52: END; $procedure$ Line 53: LANGUAGE plpgsql; Line 54: Line 55: DROP TYPE IF EXISTS GetDisks_VmGuid_BasicView_rs CASCADE; Please change to disks_basic_rs Line 56: CREATE TYPE GetDisks_VmGuid_BasicView_rs AS (disk_id UUID,disk_alias varchar(255),size BIGINT); Line 57: Line 58: Create or replace FUNCTION GetDisks_VmGuid_BasicView(v_vm_guid UUID, v_only_plugged BOOLEAN, v_user_id UUID, v_is_filtered BOOLEAN) Line 59: RETURNS SETOF GetDisks_VmGuid_BasicView_rs Line 54: Line 55: DROP TYPE IF EXISTS GetDisks_VmGuid_BasicView_rs CASCADE; Line 56: CREATE TYPE GetDisks_VmGuid_BasicView_rs AS (disk_id UUID,disk_alias varchar(255),size BIGINT); Line 57: Line 58: Create or replace FUNCTION GetDisks_VmGuid_BasicView(v_vm_guid UUID, v_only_plugged BOOLEAN, v_user_id UUID, v_is_filtered BOOLEAN) Please change to GetDisksVmGuidBasicView Line 59: RETURNS SETOF GetDisks_VmGuid_BasicView_rs Line 60: AS $procedure$ Line 61: BEGIN Line 62: RETURN QUERY SELECT disk_id,disk_alias, size Line 58: Create or replace FUNCTION GetDisks_VmGuid_BasicView(v_vm_guid UUID, v_only_plugged BOOLEAN, v_user_id UUID, v_is_filtered BOOLEAN) Line 59: RETURNS SETOF GetDisks_VmGuid_BasicView_rs Line 60: AS $procedure$ Line 61: BEGIN Line 62: RETURN QUERY SELECT disk_id,disk_alias, size Please remove TWS Line 63: FROM images Line 64: LEFT OUTER JOIN base_disks ON images.image_group_id = base_disks.disk_id Line 65: LEFT JOIN vm_device ON vm_device.device_id = image_group_id AND (NOT v_only_plugged OR is_plugged) Line 66: WHERE vm_device.vm_id = v_vm_guid -- To view, visit http://gerrit.ovirt.org/16657 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iceb6e518936f65403561703e6b70920fbcc1f07c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <liran.zel...@gmail.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Liran Zelkha <liran.zel...@gmail.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
