liron aravot has posted comments on this change.
Change subject: backend,webadmin: Enable virtual drive size extension
......................................................................
Patch Set 16: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExtendImageSizeCommand.java
Line 78: setSucceeded(true);
Line 79: }
Line 80:
Line 81: private void updateRelevantVms() {
Line 82: List<VM> vms = getVmsDiskPluggedTo();
I still think that this part needs to be changed,
1. when updating non shareable disk - there's no need to load the vms (perform
db query) as we already know that disk single vm id.
2. when having a shareable disk, we might perform here many unneeded operations
as we need to update only the running vms - this might lead to incorrect audit
log : when all the vms of a shareable disk won't be running, we will get an
audit log with irrelevant message for all of the vms which is annoying and not
user friendly.
i think that this method should be split into 2 methods -
a. updateNonShareableDiskVm()
b. updateShareableDiskVms()
which will have proper documentation on why the update of the vms happens only
when they run for non shareable disk..i think that it will be clearer.
Line 83:
Line 84: for (VM vm : vms) {
Line 85: try {
Line 86: VDSReturnValue ret = extendVmDiskSize(vm,
getParameters().getNewSize());
--
To view, visit http://gerrit.ovirt.org/14975
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie702348a68a26ac02a01f66aaa1ea42c2c675ebb
Gerrit-PatchSet: 16
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgot...@redhat.com>
Gerrit-Reviewer: A Burden <abur...@redhat.com>
Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Cheryn Tan <cheryn...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Liron Ar <lara...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: liron aravot <liron.ara...@gmail.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
