Alon Bar-Lev has posted comments on this change.
Change subject: engine: Install Openstack agents on the host
......................................................................
Patch Set 2: (3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java
Line 218: /**
Line 219: * Values to determine when customization should be performed.
Line 220: */
Line 221: private static enum CustomizationCondition {
Line 222: IPTABLES_OVERRIDE, NEUTRON_SETUP, NEUTRON_LINUX_BRIDGE_SETUP,
NEUTRON_OPEN_VSWITCH_SETUP
each one at new line please
Line 223: };
Line 224: /**
Line 225: * Special annotation to specify when the customization is
necessary.
Line 226: */
Line 436: }},
Line 437: new Callable<Void>()
{@CallWhen(CustomizationCondition.NEUTRON_SETUP)
Line 438: public Void call() throws Exception {
Line 439: _parser.cliEnvironmentSet(
Line 440: "OPENSTACK/neutronEnable",
you need to depend on recent ovirt-host-deploy at pom.xml and use the constants.
Line 441: true
Line 442: );
Line 443: return null;
Line 444: }},
Line 1107: public void
setOpenStackAgentProperties(OpenstackNetworkProviderProperties properties) {
Line 1108: _openStackAgentProperties = properties;
Line 1109: if (_openStackAgentProperties != null) {
Line 1110:
_customizationConditions.add(CustomizationCondition.NEUTRON_SETUP);
Line 1111: if
(OpenstackNetworkPluginType.LINUX_BRIDGE.name().equals(_openStackAgentProperties.getPluginType()))
{
can't we have simple condition? example ask the class?
_openStackAgentProperties.isLinuxBridge()
_openStackAgentProperties.isOpenVSwitch()
Line 1112:
_customizationConditions.add(CustomizationCondition.NEUTRON_LINUX_BRIDGE_SETUP);
Line 1113: }
Line 1114: else if
(OpenstackNetworkPluginType.OPEN_VSWITCH.name().equals(_openStackAgentProperties.getPluginType()))
{
Line 1115:
_customizationConditions.add(CustomizationCondition.NEUTRON_OPEN_VSWITCH_SETUP);
--
To view, visit http://gerrit.ovirt.org/16851
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib365bc5e7db9b0c1d070eb9182b554cd830e797d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
