Ravi Nori has uploaded a new change for review.

Change subject: sdk: unclear error message when logging into cli with bad 
formatted url
......................................................................

sdk: unclear error message when logging into cli with bad formatted url

rhevm-shell -c -d -l localhost -u admin@internal -I

throws an unclear error message.

Error happens only when connecting to engine with out
specifying the http protocol

Change-Id: Ib3665d8714258ad8e449638fbf0b86105f813e3e
Bug-Url: https://bugzilla.redhat.com/960876
Signed-off-by: Ravi Nori <rn...@redhat.com>
---
M src/ovirtsdk/infrastructure/connectionspool.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine-sdk refs/changes/86/16886/1

diff --git a/src/ovirtsdk/infrastructure/connectionspool.py 
b/src/ovirtsdk/infrastructure/connectionspool.py
index cc179cf..194d955 100644
--- a/src/ovirtsdk/infrastructure/connectionspool.py
+++ b/src/ovirtsdk/infrastructure/connectionspool.py
@@ -116,7 +116,7 @@
         parsed_url = urlparse.urlparse(url)
         domains = [parsed_url.hostname]
 
-        if parsed_url.hostname == LOCAL_HOST:
+        if parsed_url.hostname == LOCAL_HOST or url == LOCAL_HOST:
             return domains.append(LOCAL_HOST + '.local')
 
         return domains


-- 
To view, visit http://gerrit.ovirt.org/16886
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib3665d8714258ad8e449638fbf0b86105f813e3e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rn...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to