Ori Liel has posted comments on this change.
Change subject: core, restapi: cloud-init [2/6] - custom volume id in VM Payload
......................................................................
Patch Set 9: (1 inline comment)
....................................................
File
backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java
Line 850: if (deviceType!=null) {
Line 851: entity.setType(map(deviceType, null));
Line 852: }
Line 853: }
Line 854: entity.setVolumeId(model.getVolumeId());
First check if the volume-id is not null. This mapping (API-->Engine) might be
invoked in the context of update, and if the user did not update the volume-id,
then, without this check, you could find yourself overriding a valid value with
'null'.
Line 855: if (model.getFile() != null) {
Line 856: for (PayloadFile file : model.getFile()) {
Line 857: entity.getFiles().put(file.getName(),
file.getContent());
Line 858: }
--
To view, visit http://gerrit.ovirt.org/14349
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I30a3be934869c62ed4cdd9942e7fe17af67572e0
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Shahar Havivi <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
