Yair Zaslavsky has posted comments on this change.
Change subject: core: Fixes RTE while reorder LDAP servers list
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
Minor comment
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/DirectorySearcher.java
Line 74: return null;
Line 75: }
Line 76:
Line 77: List<URI> ldapServerURIs = domain.getLdapServers();
Line 78: List<URI> editableLdapServerURIs = new ArrayList<>();
Can't we have new ArrayList<>(ldapServerURIs) ?
Line 79: editableLdapServerURIs.addAll(ldapServerURIs);
Line 80: if (log.isDebugEnabled()) {
Line 81: log.debug("Ldap server list: " +
StringUtils.join(ldapServerURIs, ", "));
Line 82: }
--
To view, visit http://gerrit.ovirt.org/16859
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idc52415ca123790e967e0f1b940fdedb4987097a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mper...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
