Frank Kobzik has posted comments on this change.

Change subject: restapi: Make adding (virtio-)console to virtual machines 
optional
......................................................................


Patch Set 4: No score

(1 inline comment)

....................................................
File 
backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmsResourceTest.java
Line 586:     public void testAdd() throws Exception {
Line 587:         setUriInfo(setUpBasicUriExpectations());
Line 588:         setUpGetPayloadExpectations(1, 2);
Line 589:         setUpGetBallooningExpectations(1, 2);
Line 590:         setUpGetConsoleExpectations(new int[]{1,2});
oh no, my mistake. i must have overlooked this.
Line 591:         setUpEntityQueryExpectations(VdcQueryType.GetVmTemplate,
Line 592:                                      GetVmTemplateParameters.class,
Line 593:                                      new String[] { "Id" },
Line 594:                                      new Object[] { GUIDS[1] },


-- 
To view, visit http://gerrit.ovirt.org/16454
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I733e4c4a9c7d8f5dbe68b6b26a49502b8a40ec9d
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to