Mike Kolesnik has posted comments on this change. Change subject: openstack: neutron: initial support ......................................................................
Patch Set 3: (1 inline comment) .................................................... File src/plugins/ovirt-host-deploy/openstack/neutron.py Line 110: '--set', Line 111: odeploycons.FileLocations.OPENSTACK_NEUTRON_CONFIG, Line 112: section, Line 113: key, Line 114: '"%s"' % value, You are right, Popen doesn't require it for passing empty parameter, I'll fix it Line 115: ), Line 116: ) Line 117: Line 118: -- To view, visit http://gerrit.ovirt.org/15986 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib62d079fea94d73d1f80f519298001a89d217575 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
