Eli Mesika has uploaded a new change for review. Change subject: core: fixing NPE on ExecutionHandler ......................................................................
core: fixing NPE on ExecutionHandler Fix a NPE issue found by FindBugs http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4646/findbugsResult/module.-609324659/package.1362796474/source.6451/#288 Change-Id: I35034cd331476b6c42a266504979be848ae63c93 Signed-off-by: Eli Mesika <emes...@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/ExecutionHandler.java 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/33/16833/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/ExecutionHandler.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/ExecutionHandler.java index 9e5f3c2..eca9531 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/ExecutionHandler.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/ExecutionHandler.java @@ -295,9 +295,9 @@ } } else { Step contextStep = context.getStep(); - step.setExternal(isExternal); if (context.getExecutionMethod() == ExecutionMethod.AsStep && contextStep != null) { step = addSubStep(contextStep, stepName, description); + step.setExternal(isExternal); } } } catch (Exception e) { -- To view, visit http://gerrit.ovirt.org/16833 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I35034cd331476b6c42a266504979be848ae63c93 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
