Alon Bar-Lev has posted comments on this change. Change subject: core: Adding cleandb.sh script ......................................................................
Patch Set 1: (1 inline comment) Thanks! I will check this tomorrow. .................................................... File packaging/dbscripts/dbfunctions.sh Line 89: execute_file "drop_all_functions.sql" ${DATABASE} ${SERVERNAME} ${PORT} > /dev/null Line 90: \rm -f drop_all_functions.sql Line 91: CMD="select count(*) from pg_proc where proname = 'uuid_nil';" Line 92: if [ "$(execute_command "$CMD" ${DATABASE} ${SERVERNAME} ${PORT} | sed -e 's/ //g' -e '/^$/d')" != 0 ]; then Line 93: psql -U postgres -h ${SERVERNAME} -p ${PORT} -f drop_old_uuid_functions.sql ${DATABASE} > /dev/null hmmm... can it be possible that in 3.3 we have this? we do not have the password of postgres... nor will it work in remote database mode. Line 94: fi Line 95: CMD="DROP FUNCTION IF EXISTS uuid_generate_v1();" Line 96: execute_command "$CMD" ${DATABASE} ${SERVERNAME} ${PORT} > /dev/null Line 97: } -- To view, visit http://gerrit.ovirt.org/16832 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ff33e4ccb8cb66bbe06f5d1c8a00f22d28a2e31 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches