Arik Hadas has uploaded a new change for review. Change subject: core: fix typo ......................................................................
core: fix typo Rename RemoveVmFromImportExportParamenters class to RemoveVmFromImportExportParameters. Change-Id: I4636e5b5a1a3c26e49cb70fe32a3e7f56f4a16d0 Signed-off-by: Arik Hadas <aha...@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmFromImportExportCommand.java R backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveVmFromImportExportParameters.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainVmsResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainVmsResourceTest.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/VmBackupModel.java 5 files changed, 11 insertions(+), 11 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/29/16829/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmFromImportExportCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmFromImportExportCommand.java index 00bb9f1..50772e2 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmFromImportExportCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmFromImportExportCommand.java @@ -13,7 +13,7 @@ import org.ovirt.engine.core.bll.tasks.TaskHandlerCommand; import org.ovirt.engine.core.common.AuditLogType; import org.ovirt.engine.core.common.VdcObjectType; -import org.ovirt.engine.core.common.action.RemoveVmFromImportExportParamenters; +import org.ovirt.engine.core.common.action.RemoveVmFromImportExportParameters; import org.ovirt.engine.core.common.action.VdcActionType; import org.ovirt.engine.core.common.action.VdcReturnValueBase; import org.ovirt.engine.core.common.asynctasks.AsyncTaskCreationInfo; @@ -35,7 +35,7 @@ import org.ovirt.engine.core.dal.dbbroker.DbFacade; @NonTransactiveCommandAttribute -public class RemoveVmFromImportExportCommand<T extends RemoveVmFromImportExportParamenters> extends RemoveVmCommand<T> implements TaskHandlerCommand<RemoveVmFromImportExportParamenters>{ +public class RemoveVmFromImportExportCommand<T extends RemoveVmFromImportExportParameters> extends RemoveVmCommand<T> implements TaskHandlerCommand<RemoveVmFromImportExportParameters>{ // this is needed since overriding getVmTemplate() private VM exportVm; diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveVmFromImportExportParamenters.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveVmFromImportExportParameters.java similarity index 72% rename from backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveVmFromImportExportParamenters.java rename to backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveVmFromImportExportParameters.java index 30170d1..7a3a60f 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveVmFromImportExportParamenters.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveVmFromImportExportParameters.java @@ -2,16 +2,16 @@ import org.ovirt.engine.core.compat.Guid; -public class RemoveVmFromImportExportParamenters extends RemoveVmParameters implements java.io.Serializable { +public class RemoveVmFromImportExportParameters extends RemoveVmParameters implements java.io.Serializable { private static final long serialVersionUID = 1841755064122049392L; private Guid storagePoolId = Guid.Empty; private Guid storageDomainId = Guid.Empty; - public RemoveVmFromImportExportParamenters() { + public RemoveVmFromImportExportParameters() { } - public RemoveVmFromImportExportParamenters(Guid vmId, Guid storageDomainId, Guid storagePoolId) { + public RemoveVmFromImportExportParameters(Guid vmId, Guid storageDomainId, Guid storagePoolId) { super(vmId, false); setStorageDomainId(storageDomainId); setStoragePoolId(storagePoolId); diff --git a/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainVmsResource.java b/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainVmsResource.java index 09691a3..8fa9ee9 100644 --- a/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainVmsResource.java +++ b/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainVmsResource.java @@ -9,7 +9,7 @@ import org.ovirt.engine.api.resource.RemovableStorageDomainContentsResource; import org.ovirt.engine.api.resource.StorageDomainContentResource; import org.ovirt.engine.api.restapi.utils.GuidUtils; -import org.ovirt.engine.core.common.action.RemoveVmFromImportExportParamenters; +import org.ovirt.engine.core.common.action.RemoveVmFromImportExportParameters; import org.ovirt.engine.core.common.action.VdcActionType; import org.ovirt.engine.core.common.queries.GetAllFromExportDomainQueryParameters; import org.ovirt.engine.core.common.queries.VdcQueryType; @@ -52,7 +52,7 @@ @Override public Response performRemove(String id) { - RemoveVmFromImportExportParamenters params = new RemoveVmFromImportExportParamenters( + RemoveVmFromImportExportParameters params = new RemoveVmFromImportExportParameters( GuidUtils.asGuid(id), storageDomainId, getDataCenterId(storageDomainId)); diff --git a/backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainVmsResourceTest.java b/backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainVmsResourceTest.java index 07bdad2..10c7d42 100644 --- a/backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainVmsResourceTest.java +++ b/backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainVmsResourceTest.java @@ -9,7 +9,7 @@ import org.junit.Test; import org.ovirt.engine.api.model.VM; -import org.ovirt.engine.core.common.action.RemoveVmFromImportExportParamenters; +import org.ovirt.engine.core.common.action.RemoveVmFromImportExportParameters; import org.ovirt.engine.core.common.action.VdcActionType; import org.ovirt.engine.core.common.businessentities.StorageDomainType; @@ -84,7 +84,7 @@ setUpGetDataCenterByStorageDomainExpectations(GUIDS[3], 2); String[] names = new String[]{"VmId", "StorageDomainId", "StoragePoolId"}; Object[] values = new Object[]{GUIDS[0], GUIDS[3], DATA_CENTER_ID}; - setUpActionExpectations(VdcActionType.RemoveVmFromImportExport, RemoveVmFromImportExportParamenters.class, names, values, true, true); + setUpActionExpectations(VdcActionType.RemoveVmFromImportExport, RemoveVmFromImportExportParameters.class, names, values, true, true); verifyRemove(collection.remove(GUIDS[0].toString())); } diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/VmBackupModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/VmBackupModel.java index cfc435d..d20c3ba 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/VmBackupModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/VmBackupModel.java @@ -10,7 +10,7 @@ import java.util.Set; import org.ovirt.engine.core.common.action.ImportVmParameters; -import org.ovirt.engine.core.common.action.RemoveVmFromImportExportParamenters; +import org.ovirt.engine.core.common.action.RemoveVmFromImportExportParameters; import org.ovirt.engine.core.common.action.VdcActionParametersBase; import org.ovirt.engine.core.common.action.VdcActionType; import org.ovirt.engine.core.common.action.VdcReturnValueBase; @@ -141,7 +141,7 @@ new ArrayList<VdcActionParametersBase>(); for (Object item : backupModel.getSelectedItems()) { VM vm = (VM) item; - list.add(new RemoveVmFromImportExportParamenters(vm.getId(), + list.add(new RemoveVmFromImportExportParameters(vm.getId(), backupModel.getEntity().getId(), pool.getId())); } -- To view, visit http://gerrit.ovirt.org/16829 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4636e5b5a1a3c26e49cb70fe32a3e7f56f4a16d0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <aha...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches