Arik Hadas has uploaded a new change for review.
Change subject: core: use Collections#EMPTY_MAP instead of new map
......................................................................
core: use Collections#EMPTY_MAP instead of new map
In VmHandler#findStorageDomainForMemory(Guid, long) we create everytime
a new map and pass it on. This new map is empty map and no one adds
anything to it, so we can use the singleton map Collections#EMPTY_MAP
instead.
Change-Id: I4053e06f17827d8afbdc48ad006897c029426384
Signed-off-by: Arik Hadas <aha...@redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/23/16823/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java
index 88e8c39..040d81e 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java
@@ -1,7 +1,7 @@
package org.ovirt.engine.core.bll;
import java.util.Arrays;
-import java.util.HashMap;
+import java.util.Collections;
import java.util.List;
import java.util.Map;
@@ -503,7 +503,7 @@
* or null if no such storage domain exists in the pool
*/
public static StorageDomain findStorageDomainForMemory(Guid storagePoolId,
long sizeRequested) {
- return findStorageDomainForMemory(storagePoolId, sizeRequested, new
HashMap<StorageDomain, Integer>());
+ return findStorageDomainForMemory(storagePoolId, sizeRequested,
Collections.<StorageDomain, Integer>emptyMap());
}
/**
--
To view, visit http://gerrit.ovirt.org/16823
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4053e06f17827d8afbdc48ad006897c029426384
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <aha...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
