Yair Zaslavsky has posted comments on this change.
Change subject: core: host-deploy: Using ssh username and password to install
and update host
......................................................................
Patch Set 9: (3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java
Line 326: if (Config.<Boolean>
GetValue(ConfigValues.UseSecureConnectionWithServers)
Line 327: && !EngineEncryptionUtils.haveKey()) {
Line 328: returnValue =
failCanDoAction(VdcBllMessages.VDS_TRY_CREATE_SECURE_CERTIFICATE_NOT_FOUND);
Line 329: } else if (!getParameters().getAddPending()
Line 330: &&
StringUtils.isEmpty(getParameters().getPassword())) {
Can contain whitespaces? if not - I suggest using isBlank.
Line 331: // We block vds installations if it's not a
RHEV-H and password is empty
Line 332: // Note that this may override local host SSH
policy. See BZ#688718.
Line 333: returnValue =
failCanDoAction(VdcBllMessages.VDS_CANNOT_INSTALL_EMPTY_PASSWORD);
Line 334: } else if (!isPowerManagementLegal()) {
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsCommand.java
Line 86: && _oldVds.getStatus() !=
VDSStatus.NonOperational
Line 87: && _oldVds.getStatus() !=
VDSStatus.InstallFailed) {
Line 88:
addCanDoActionMessage(VdcBllMessages.VDS_CANNOT_INSTALL_STATUS_ILLEGAL);
Line 89: } else if (getParameters().getInstallVds()
Line 90: &&
StringUtils.isEmpty(getParameters().getPassword())
Same question as before about whitespaces.
Line 91: &&
getParameters().getVdsStaticData().getVdsType() == VDSType.VDS) {
Line 92:
addCanDoActionMessage(VdcBllMessages.VDS_CANNOT_INSTALL_EMPTY_PASSWORD);
Line 93: } else if (!getParameters().getInstallVds()
Line 94: && _oldVds.getPort() !=
getParameters().getVdsStaticData().getPort()) {
....................................................
File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
Line 521: -Please remove VLAN from the interface.
Line 522: NETWORK_ALREADY_ATTACHED_TO_CLUSTER=Logical Network is already
attached to Cluster.
Line 523: ACTION_TYPE_FAILED_VDS_WITH_SAME_HOST_EXIST=Cannot ${action} ${type}.
Host with the same address already exists.
Line 524: ACTION_TYPE_FAILED_VDS_WITH_INVALID_SSH_PORT=Cannot ${action}
${type}. Invalid SSH port was entered.
Line 525: ACTION_TYPE_FAILED_VDS_WITH_INVALID_SSH_USERNAME=Cannot ${action}
${type}. Invalid SSH user-name was entered.
Are we ok with user-name, don't you want user name?
Line 526: ACTION_TYPE_FAILED_VDS_WITH_SAME_UUID_EXIST=Cannot ${action} ${type}.
Host with the same UUID already exists.
Line 527: ACTION_TYPE_FAILED_ILLEGAL_MEMORY_SIZE=Cannot ${action} ${type}.
Illegal memory size is provided, size needs to be between ${minMemorySize} MB
and ${maxMemorySize} MB.
Line 528: ACTION_TYPE_FAILED_ILLEGAL_NUM_OF_MONITORS=Cannot ${action} ${type}.
Illegal number of monitors is provided, max allowed number of monitors is 1 for
VNC and the max number in the ValidNumOfMonitors configuration variable for
SPICE.
Line 529: ACTION_TYPE_FAILED_ILLEGAL_DOMAIN_NAME=Cannot ${action} ${type}.
Illegal Domain name: ${Domain}. Domain name has unsupported special character
${Char}.
--
To view, visit http://gerrit.ovirt.org/16686
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d9b23771314ebebb3e10686decb4f0d5ace6d3c
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
