Eli Mesika has posted comments on this change.

Change subject: core: Adding AddExternalStepCommand
......................................................................


Patch Set 13: (1 inline comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddExternalStepCommand.java
Line 49:         if (job == null && parentStep == null) {
Line 50:             retValue=false;
Line 51:             
addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_NO_PARENT);
Line 52:         }
Line 53:         if 
(StringUtils.isEmpty(getParameters().getDescription().trim())) {
Done
Line 54:             retValue=false;
Line 55:             
addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_EMPTY_DESCRIPTION);
Line 56:         }
Line 57:         if (!retValue) {


-- 
To view, visit http://gerrit.ovirt.org/15227
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I014a4911873ebe7c8dc37b6504655b377d73da3e
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to