Moti Asayag has posted comments on this change.

Change subject: core: Add vnic profiles to DB and entities
......................................................................


Patch Set 25:

He Eli,

Please note regarding you comment about naming convention that we have the 
following class in the system:
  /dal/src/main/java/org/ovirt/engine/core/dao/DefaultGenericDaoDbFacade.java 

which actually dictates a difference naming convention for the stored procedure:
 InsertVnicProfile
 RemoveVnicPRofile
 ...

I tend to modify the VnicProfileDao and the stored procedures accordingly.

-- 
To view, visit http://gerrit.ovirt.org/15992
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id0525a6d30995fe896499fed283638b93cae5e41
Gerrit-PatchSet: 25
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to