Giuseppe Vallarelli has posted comments on this change.
Change subject: core: Add parameter class for vnic profile commands
......................................................................
Patch Set 7: I would prefer that you didn't submit this
(1 inline comment)
Asking a question.
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VnicProfileParameters.java
Line 9: private static final long serialVersionUID = 7238781812367042839L;
Line 10:
Line 11: @Valid
Line 12: private VnicProfile vnicProfile;
Line 13: private boolean publicUse;
Is there a specific reason why you don't initialize publicUse in one of the
constructor? It should default to false. I guess because when created
VnicProfiles are not for public use and then a change perhaps in the ui layer
(marking it as public) triggers the setPublicUse.
Line 14:
Line 15: public VnicProfileParameters() {
Line 16: }
Line 17:
--
To view, visit http://gerrit.ovirt.org/16671
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia98a96e4413f1b9cbc7012c2e2fc6da70a4027e4
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
