Allon Mureinik has posted comments on this change.

Change subject: core: [logging] Add the host name to the logging context
......................................................................


Patch Set 2: (1 inline comment)

Love the idea, please see Juan's comment about where you import MDC from.

....................................................
Commit Message
Line 9: This patch uses log4j MDC [1] which is a key-value map
Line 10: of string an application puts on the Thread-local and can be used in 
the
Line 11: logging.
Line 12: 
Line 13: This greatly improves and simplifies logging in the Various VdsManager
s/Various/various/
Line 14: flows.
Line 15: 
Line 16: Every line of log from VdsManager threads will look something like:
Line 17:   [org.ovirt.engine.core.vdsbroker.VdsManager]


-- 
To view, visit http://gerrit.ovirt.org/16548
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iafad27da56400741974132c956f90ba937c20a98
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to