Daniel Erez has posted comments on this change.
Change subject: webadmin,userportal: Upgrade GWT SDK and related modules
......................................................................
Patch Set 1: (8 inline comments)
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/popup/ConsolePopupPresenterWidget.java
Line 250:
Line 251: // store to local storage
Line 252:
consoleOptionsPersister.storeToLocalStorage(model.getModel());
Line 253:
Line 254: ConsoleModelChangedEvent.fire(this, model.getModel());
just wondering, is it related to the upgrade? or, has it simply been
incorrect...
Line 255: }
Line 256: }
Line 257:
Line 258: protected boolean isAdditionalConsoleAvailable(HasConsoleModel
currentItem) {
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmRunOncePopupWidget.java
Line 132: @WithElementId("runAndPause")
Line 133: EntityModelCheckBoxEditor runAndPauseEditor;
Line 134:
Line 135: @UiField
Line 136: @Path(value = "kernel_path.entity")
how did the binding worked all along? :)
Line 137: @WithElementId("kernelPath")
Line 138: EntityModelTextBoxEditor kernelPathEditor;
Line 139:
Line 140: @UiField
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/IscsiStorageView.ui.xml
Line 51: </g:VerticalPanel>
Line 52: <t:DialogTabPanel ui:field="dialogTabPanel"
height="340px" width="100%" addStyleNames="{style.tabPanel}">
Line 53: <t:tab>
Line 54: <t:DialogTab ui:field="targetsToLunTab">
Line 55: <t:content>
why is it redundant?
Line 56: <w:ValidatedPanelWidget
ui:field="targetsToLunsPanel" addStyleNames="{style.tabContentPanel}" />
Line 57: </t:content>
Line 58: </t:DialogTab>
Line 59: </t:tab>
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/template/TemplateGeneralModelForm.java
Line 20: TextBoxLabel name = new TextBoxLabel();
Line 21: TextBoxLabel description = new TextBoxLabel();
Line 22: TextBoxLabel hostCluster = new TextBoxLabel();
Line 23: TextBoxLabel definedMemory = new TextBoxLabel();
Line 24: @Path("OS")
why is it required now?
Line 25: TextBoxLabel oS = new TextBoxLabel();
Line 26: TextBoxLabel cpuInfo = new TextBoxLabel();
Line 27: TextBoxLabel defaultDisplayType = new TextBoxLabel();
Line 28: TextBoxLabel origin = new TextBoxLabel();
Line 102: @Override
Line 103: protected void doEdit(TemplateGeneralModel model) {
Line 104: driver.edit(model);
Line 105:
Line 106: // Required because of type conversion
now that GWT issue #5864 is resolved, is it really still mandatory? iirc, some
other views have been affected by issue 5864 as well...
Line 107:
monitorCount.setText(Integer.toString(getModel().getMonitorCount()));
Line 108:
isStateless.setText(Boolean.toString(getModel().getIsStateless()));
Line 109: }
Line 110:
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/PoolInterfaceListModelTable.java
Line 141:
Line 142: TextColumnWithTooltip<VmNetworkInterface> dropsColumn = new
SumUpColumn<VmNetworkInterface>() {
Line 143: @Override
Line 144: protected Double[] getRawValue(VmNetworkInterface object)
{
Line 145: Double receiveDropRate = object != null ?
object.getStatistics().getReceiveDropRate() : null;
hmm, just a minor suggestion :)
consider early return instead, i.e.:
if (object == null) {
return new Double[2];
}
Line 146: Double transmitDropRate = object != null ?
object.getStatistics().getTransmitDropRate() : null;
Line 147: return new Double[] { receiveDropRate,
transmitDropRate };
Line 148: }
Line 149: };
....................................................
File frontend/webadmin/modules/pom.xml
Line 164: <bindAddress>0.0.0.0</bindAddress>
Line 165: <gen>${gwtGenDirectory}</gen>
Line 166: <extraJvmArgs>${aspectj.agent} ${gwt-plugin.extraJvmArgs}
${gwt.dontPrune}</extraJvmArgs>
Line 167: <copyWebapp>true</copyWebapp>
Line 168: <strict>true</strict>
why do we want to enforce strict mode?
Line 169: <compileSourcesArtifacts>
Line 170:
<compileSourcesArtifact>${engine.groupId}:gwt-extension</compileSourcesArtifact>
Line 171:
<compileSourcesArtifact>${engine.groupId}:uicommonweb</compileSourcesArtifact>
Line 172: </compileSourcesArtifacts>
....................................................
File
frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/WebAdmin.gwt.xml
Line 28
Line 29
Line 30
Line 31
Line 32
how come it's not needed any more?
--
To view, visit http://gerrit.ovirt.org/16739
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ica797e68e2f56fd3f231baf36f0ac03c5df5c3f2
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
