Giuseppe Vallarelli has posted comments on this change.

Change subject: engine: Remove vnic profiles of a removed a data-center
......................................................................


Patch Set 2: Looks good to me, but someone else must approve

(1 inline comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStoragePoolCommand.java
Line 96:                 final List<Network> networks = 
getNetworkDAO().getAllForDataCenter(getStoragePoolId());
Line 97:                 for (final Network net : networks) {
Line 98:                     List<VnicProfile> profiles = 
getDbFacade().getVnicProfileDao().getAllForNetwork(net.getId());
Line 99:                     for (VnicProfile vnicProfile : profiles) {
Line 100:                         
getCompensationContext().snapshotEntity(vnicProfile);
All right.
Line 101:                         
getDbFacade().getVnicProfileDao().remove(vnicProfile.getId());
Line 102:                     }
Line 103:                     getCompensationContext().snapshotEntity(net);
Line 104:                     getNetworkDAO().remove(net.getId());


-- 
To view, visit http://gerrit.ovirt.org/16789
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb399dc916983780be9895278e9335e3631ad1cd
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvall...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to