Michael Pasternak has posted comments on this change.
Change subject: restapi: REST apis for gluster SWIFT maintenance
......................................................................
Patch Set 6: I would prefer that you didn't submit this
(2 inline comments)
....................................................
Commit Message
Line 9: This patch adds API support for managing gluster services.
Line 10: - api/hosts/{id}/glusterservices
Line 11: lists all gluster services in the host
Line 12: - api/hosts/{id}/glusterservices/{glusterservice:id}
Line 13: shows details of individual gluster service on the said host
we may have more services exposed via api, thus calling it glusterservice won't
make sense in a future,
i'd suggest calling this collection just /services and distinguish gluster by
adding <type>gluster</type> element in the service object
Line 14:
Line 15: Actions supported:
Line 16: - api/hosts/{id}/glusterservicestart
Line 17: starts all the gluster services in the said host for a given type
Line 17: starts all the gluster services in the said host for a given type
Line 18: - api/hosts/{id}/glusterservicestop
Line 19: stops all the gluster services in the said host for a given type
Line 20: - api/hosts/{id}/glusterservicerestart
Line 21: re-starts all the gluster services in the said host for a given type
i don't see why we need a 'gluster' prefix for in action, e.g this is common
service actions and not gluster specific, should be just start|stop|restart|etc.
Line 22:
Line 23: Change-Id: I87cb354e10fed21cbd18b874595b726d3ac018a6
--
To view, visit http://gerrit.ovirt.org/16691
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I87cb354e10fed21cbd18b874595b726d3ac018a6
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
