Eli Mesika has posted comments on this change. Change subject: core: Adding EndExternalJobCommand ......................................................................
Patch Set 13: (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EndExternalJobCommand.java Line 63: // mark job as auto-cleared Line 64: job.setAutoCleared(true); Line 65: getJobDao().update(job); Line 66: // Set all job steps and sub steps that were not completed as ABORTED Line 67: JobRepositoryFactory.getJobRepository().closeCompletedJobSteps(job.getId(), JobExecutionStatus.ABORTED); No , the set completed got a status argument which in this case is JobExecutionStatus.ABORTED) Line 68: } Line 69: setSucceeded(true); Line 70: } Line 71: -- To view, visit http://gerrit.ovirt.org/15228 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d8643e32eaecf79ac769c3b6eacef9e6330c512 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
