Einav Cohen has posted comments on this change. Change subject: HostGeneralModel: improve "node has upgrade" logic ......................................................................
Patch Set 5: Hi Douglas, a couple of comments: I think that what Doron was saying (Doron - please correct me if I am wrong) is that in case you have "ovirt-node-iso-2.6.0-20120212.fc18.noarch.rpm" installed and "ovirt-node-iso-3.0.0-20130212.fc18.noarch.rpm" available, the "node has upgrade" alert shouldn't be displayed, as upgrade is impossible in case the "major" part of the versions don't match (in this case, the installed major part of the version is "2" and the available ISO major part of the version is "3"). I think that "vdsm-compatibility.txt" is not related to Doron's comment: AFAIK, the "vdsm-compatibility" of the ISO needs to be compared against the compatibility-version of the Cluster in which the node resides; if one of the values within the "vdsm-compatibility" of the ISO matches the compatibility-version of the Cluster in which the node resides, then the ISO is valid for upgrade of this node; if there is no match - the ISO is not valid for upgrade of this node. AFAIK: All-in-all, an available ISO is valid for a node upgrade if *all* of the following conditions are fulfilled: - available ISO version is higher than the node version - "major" part of the available ISO version is identical to the "major" part of the node version - one of the available ISO's vdsm-compatibility values matches the compatibility-version of the Cluster (in oVirt-engine) in which the node resides. One more note: in your example, you mentioned that in case the node is installed with "ovirt-node-iso-2.6.1-20120228.fc18.noarch.rpm" and there is an available ISO versioned "ovirt-node-iso-2.6.0-20130212.fc18.noarch.rpm", then the "node upgrade available" notification will be displayed. my question is if this indeed should be the behavior: the node version is "2.6.1-...." and the available ISO version is "2.6.0-..." (which seems to me as a lower version, even though the "2.6.0-..." ISO is marked with a later date) - I believe that in this particular case, the "node has upgrade" alert shouldn't be displayed. thoughts? -- To view, visit http://gerrit.ovirt.org/16089 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I49c74d3d0d92c74848e0c175095610b6e6b5a88e Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsl...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsl...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
