Moti Asayag has uploaded a new change for review. Change subject: engine: Remove publicUse from AddNetwork command ......................................................................
engine: Remove publicUse from AddNetwork command Since there is no meaning for usage permissions on the network entity (replaced by the vnic profile), the publicUse option is removed from the command parameters and will also be removed from the AddNetwork dialogue. Change-Id: I3c95b56b22051da5fab5e4b5b34403fc4e2e8a03 Signed-off-by: Moti Asayag <[email protected]> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddNetworkStoragePoolParameters.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NewNetworkModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/ImportNetworksModel.java 3 files changed, 0 insertions(+), 12 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/72/16772/1 diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddNetworkStoragePoolParameters.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddNetworkStoragePoolParameters.java index d5507c6..15dea0c 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddNetworkStoragePoolParameters.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddNetworkStoragePoolParameters.java @@ -13,8 +13,6 @@ @NotNull private Network network; - private boolean publicUse; - public AddNetworkStoragePoolParameters() { } @@ -25,13 +23,5 @@ public Network getNetwork() { return network; - } - - public void setPublicUse(boolean publicUse) { - this.publicUse = publicUse; - } - - public boolean isPublicUse() { - return publicUse; } } diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NewNetworkModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NewNetworkModel.java index 477f49e..fc51947 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NewNetworkModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NewNetworkModel.java @@ -98,7 +98,6 @@ // New network final AddNetworkStoragePoolParameters parameters = new AddNetworkStoragePoolParameters(getSelectedDc().getId(), getNetwork()); - parameters.setPublicUse((Boolean) getPublicUse().getEntity()); Frontend.RunAction(VdcActionType.AddNetwork, parameters, new IFrontendActionAsyncCallback() { diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/ImportNetworksModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/ImportNetworksModel.java index 16ecf83..88ca3bf 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/ImportNetworksModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/ImportNetworksModel.java @@ -163,7 +163,6 @@ externalNetwork.getNetwork().setDataCenterId(dcId); AddNetworkStoragePoolParameters params = new AddNetworkStoragePoolParameters(dcId, externalNetwork.getNetwork()); - params.setPublicUse(externalNetwork.isPublicUse()); mulipleActionParameters.add(params); } -- To view, visit http://gerrit.ovirt.org/16772 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3c95b56b22051da5fab5e4b5b34403fc4e2e8a03 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
