Adam Litke has posted comments on this change.
Change subject: Use balloon_min to set the minimum guaranteed memory available
......................................................................
Patch Set 4: (2 inline comments)
See inline comments.
....................................................
File mom/Collectors/GuestBalloon.py
Line 19: """
Line 20: This Collector uses hypervisor interface to collect guest balloon
info
Line 21: """
Line 22: def getFields(self=None):
Line 23: return set(['balloon_cur', 'balloon_max', 'balloon_min'])
OK, thanks for your further explanation. Since the value is rooted in the
libvirt xml then I agree that it belongs in the Collector. However, I'd prefer
that it keep the libvirt given name instead of renaming it.
Line 24:
Line 25: def __init__(self, properties):
Line 26: self.hypervisor_iface = properties['hypervisor_iface']
Line 27: self.uuid = properties['uuid']
....................................................
File mom/HypervisorInterfaces/libvirtInterface.py
Line 227: if info is None:
Line 228: self.logger.error('Failed to get domain info')
Line 229: return None
Line 230: ret = {'balloon_max': info[1], 'balloon_cur': info[2],
Line 231: 'balloon_min': self._getGuaranteedMemory(domain) }
Ok. This is the source of my confusion. Can we just keep the name
min_guarantee so it is easier to reference back to the libvirt API?
Line 232: return ret
Line 233:
Line 234: def setVmBalloonTarget(self, uuid, target):
Line 235: dom = self._getDomainFromUUID(uuid)
--
To view, visit http://gerrit.ovirt.org/15801
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I376ac6b2cdadc567314899a95c6b855f820e746b
Gerrit-PatchSet: 4
Gerrit-Project: mom
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Martin Sivák <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
