Vitor de Lima has posted comments on this change. Change subject: core: Initial support for alternative architectures ......................................................................
Patch Set 1: (5 inline comments) .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/osinfo/ArchRepository.java Line 12: List<String> getArchitectureNames(); Line 13: Line 14: List<String> getDiskInterfaces(String architectureName, Version version); Line 15: Line 16: boolean isDiskHotPluggingSupported(String architectureName, Version version); We are going to submit a new patchset using only the osinfo properties file and attributing architecture specific information to the "default OS" of each arch. Line 17: Line 18: int getDefaultOs(String architectureName); .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/osinfo/OsRepository.java Line 74: Line 75: /** Line 76: * @return returns a map that associates each OS to a boolean indicating if it could be connected with SPICE Line 77: */ Line 78: public HashMap<Version, HashMap<Integer, Boolean>> getSpiceSupportMap(); yes, only the VNC display type is supported in the QEMU for POWER. Line 79: Line 80: /** Line 81: * this is Windows OSs specific path to the sysprep file Line 82: * @param osId .................................................... File packaging/conf/archinfo-defaults.properties Line 1: arch.x86_64.devices.diskInterfaces.value = ide, virtio Line 2: arch.x86_64.devices.diskInterfaces.value.version.3.3 = ide, scsi, virtio Line 3: arch.x86_64.devices.diskHotPluggingSupported.value = true Line 4: arch.x86_64.defaultOs.value = 1000 You are right, we are going to fix this in the next patchset. Line 5: Line 6: arch.ppc64.devices.diskInterfaces.value.version.3.3 = virtio Line 7: arch.ppc64.devices.diskHotPluggingSupported.value.version.3.3 = false Line 8: arch.ppc64.defaultOs.value = 1001 Line 4: arch.x86_64.defaultOs.value = 1000 Line 5: Line 6: arch.ppc64.devices.diskInterfaces.value.version.3.3 = virtio Line 7: arch.ppc64.devices.diskHotPluggingSupported.value.version.3.3 = false Line 8: arch.ppc64.defaultOs.value = 1001 We are thinking about another way to get the Id of the default OS for each architecture. We could search the osinfo properties file for a OS with a specific unique name (like "Other_x86_64"), or we could search for a OS that is not derived from any other OS. Or we could do it another way... which is the best option, in your opinion? .................................................... File packaging/conf/osinfo-defaults.properties Line 61: os.Unassigned_ppc64.resources.minimum.disksize.value = 1 Line 62: os.Unassigned_ppc64.resources.minimum.numberOsCpus.value = 1 Line 63: os.Unassigned_ppc64.spiceSupport.value = false Line 64: os.Unassigned_ppc64.devices.audio.value = ich6 Line 65: os.Unassigned_ppc64.devices.network.value = pv Ok, the next patchset will use the "Other". We are going to add more OSes later. Line 66: Line 67: os.linux.id.value = 100 Line 68: os.linux.name.value = Linux Line 69: os.linux.derivedFrom.value = Unassigned_x86_64 -- To view, visit http://gerrit.ovirt.org/16700 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I33ed9231a6467aa59e8f3223ba9d61b6e68039fa Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Vitor de Lima <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
