Alon Bar-Lev has posted comments on this change.
Change subject: oVirt Node Upgrade: Support N configuration
......................................................................
Patch Set 11: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsValidator.java
Line 101: }
Line 102: } else {
Line 103: result = IsoValidStatus.MISSINGFILE;
Line 104: }
Line 105: break;
so far the backend created a list of images from single directory, return the
list to the ui for user to select.
as it was only single directory it was obvious that the name of the file exist
in that directory. There was no guessing, it was 1:1.
now we have multiple directories, so when enum files, we should return
something to UI that will allow us to perform 1:1 match when we are asked to,
and not search for the file again.
I don't want to make it harder for you as there is security issue that need to
be dealt with, to allow receiving files that are valid within the search path.
Thinking of it... please verify that file name you receive from UI does not
contain '/'.
Line 106: }
Line 107: }
Line 108: }
Line 109: }
--
To view, visit http://gerrit.ovirt.org/14756
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfb9dc5d0dc8780b519107acbe0ae866831f782c
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsl...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsl...@redhat.com>
Gerrit-Reviewer: Michael Burns <mbu...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
