Yair Zaslavsky has posted comments on this change. Change subject: core: host-deploy: Adding ssh_username and ssh_port to VDS object - VdsStatic fields ......................................................................
Patch Set 3: Looks good to me, but someone else must approve I am ok with that. Next time, when you rename fields / getters/setters (sshkeyfingerprint) do that in separate patch. -- To view, visit http://gerrit.ovirt.org/16684 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia968dbb669f997dd7eb51e618270110aacbf50b3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
