Vojtech Szocs has posted comments on this change.
Change subject: frontend: restyle VM dialog header
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/tab/DialogTabPanel.ui.xml
Line 22: .header {
Line 23: background-color: #e5e5e5;
Line 24: margin-bottom: 15px;
Line 25: padding-top: 6px;
Line 26: /*Neutralize the 5px padding of the parent*/
Minor thing: ui.xml files generally use TAB chars for indentation, so I suggest
using TAB or just reformat ui.xml to use 4-space for indentation.
Line 27: margin-left: -5px;
Line 28: border: 2px solid #d3d3d3;
Line 29: display: none;
Line 30: }
--
To view, visit http://gerrit.ovirt.org/16717
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If51788855a6e39b7549dd44206cccf5d0256ddf1
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
